Remove native named pipes implementation #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
approved these changes
Mar 16, 2019
SeeminglyScience
approved these changes
Mar 17, 2019
src/PowerShellEditorServices.Protocol/MessageProtocol/Channel/NamedPipeServerListener.cs
Show resolved
Hide resolved
| @@ -765,7 +765,7 @@ public Task<RunspaceHandle> GetRunspaceHandleAsync(CancellationToken cancellatio | |||
| executionOptions, | |||
| true); | |||
|
|
|||
| throw e; | |||
| throw; | |||
rjmholt
approved these changes
Mar 22, 2019
| @@ -160,13 +160,12 @@ private async Task OnExecutionCompletedAsync(Task executeTask) | |||
| // Respond to the disconnect request and stop the server | |||
| await _disconnectRequestContext.SendResultAsync(null); | |||
| Stop(); | |||
| return; | |||
TylerLeonhardt
force-pushed
the
switch-named-pipes
branch
from
a25a281 to
efe6358
Compare
|
@PoshChan please remind me in 10 minutes |
|
@TylerLeonhardt, will remind you in 10 minutes |
|
@TylerLeonhardt, this is the reminder you requested 10 minutes ago |
TylerLeonhardt
force-pushed
the
switch-named-pipes
branch
from
efe6358 to
7d68b9b
Compare
TylerLeonhardt
force-pushed
the
switch-named-pipes
branch
from
b9150fb to
5d11aee
Compare
4 tasks
|
this PR now checks for 6.0 |
rjmholt
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PowerShell Core 6.0 is EOL, all PowerShell Core versions are built on .NET Core 2.1!
This means that we can take advantage of things added to 2.1, namely the CurrentUserOnly flag on PipeOptions which sets up your named pipes so that only the current user can access them.
Because of this, we can remove the Native Pipe implementation that we took from PowerShell Core.
This needs a PR over to vscode-powershell that says PowerShell Core 6.0 is not supported... but the important change is in this PR.